Fix: Prevent deadlocks during mtime/size/etag propagation #34302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raudius
force-pushed
the
fix/propagation_deadlock_handling
branch
3 times, most recently
from
ff32a09
to
372e8a9
Compare
|
Wondering whether we could move the retry logic to |
szaimen
requested review from
a team,
juliushaertl and
CarlSchwan
and removed request for
a team
Raudius
added
3. to review
icewind1991
reviewed
Sep 29, 2022
icewind1991
approved these changes
Sep 29, 2022
Raudius
force-pushed
the
fix/propagation_deadlock_handling
branch
3 times, most recently
from
6c69d3c
to
2176849
Compare
CarlSchwan
reviewed
Sep 30, 2022
Raudius
force-pushed
the
fix/propagation_deadlock_handling
branch
2 times, most recently
from
5491c55
to
3db1f6d
Compare
icewind1991
reviewed
Oct 1, 2022
Signed-off-by: raul <raul@nextcloud.com>
…ion storage is enabled Signed-off-by: raul <raul@nextcloud.com>
Raudius
force-pushed
the
fix/propagation_deadlock_handling
branch
from
fa454bb
to
95bc770
Compare
|
/backport to stable25 |
|
/backport to stable24 |
juliushaertl
reviewed
Oct 3, 2022
juliushaertl
approved these changes
Oct 3, 2022
icewind1991
approved these changes
Oct 3, 2022
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
The backport to stable24 failed. Please do this backport manually. |
|
@Raudius there is a bunch of issues about deadlocks; can you please check if this PR can help on some of them? 👍 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading many files in one go deadlocks can occur when propagating the changes. This PR performs two changes which should help prevent deadlocks: